Skip to content

refactor: utility methods into separate internal package for reuse in std library#1258

Merged
yelhousni merged 4 commits intomasterfrom
refactor/limb-composition
Aug 23, 2024
Merged

refactor: utility methods into separate internal package for reuse in std library#1258
yelhousni merged 4 commits intomasterfrom
refactor/limb-composition

Conversation

@ivokub
Copy link
Copy Markdown
Collaborator

@ivokub ivokub commented Aug 23, 2024

Description

Refactor the utility methods to internal package for convenient reuse.

Type of change

  • Refactoring, no breakage

How has this been tested?

All existing unit tests succeed.

Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I did not modify files generated from templates
  • golangci-lint does not output errors locally
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@ivokub ivokub requested a review from yelhousni August 23, 2024 08:36
@ivokub ivokub self-assigned this Aug 23, 2024
@ivokub
Copy link
Copy Markdown
Collaborator Author

ivokub commented Aug 23, 2024

Pinging @Tabaie - I also refactored some stuff related to GKR and compression. The motivation was to have a clean set of packages in std/, as the algo_utils and test_vector_utils packages seemed to be utility packages. But if it does break any current work, then I can revert the commit a111226

Copy link
Copy Markdown
Contributor

@yelhousni yelhousni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and works seamlessly on my other branch!

@yelhousni yelhousni merged commit fdb2b0d into master Aug 23, 2024
@yelhousni yelhousni deleted the refactor/limb-composition branch August 23, 2024 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants