Skip to content

chore: up gnark-crypto#1274

Merged
gbotrel merged 1 commit intomasterfrom
chore/up-gnark-crypto
Sep 10, 2024
Merged

chore: up gnark-crypto#1274
gbotrel merged 1 commit intomasterfrom
chore/up-gnark-crypto

Conversation

@yelhousni
Copy link
Copy Markdown
Contributor

Description

update gnark-crypto to latest which removes support of BLS12-378 and BW6-756 curves

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How has this been tested?

wrapped_hash_test.go in std/recursion passes.

How has this been benchmarked?

N/A

Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I did not modify files generated from templates
  • golangci-lint does not output errors locally
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@yelhousni yelhousni requested review from gbotrel and ivokub and removed request for ivokub September 10, 2024 13:26
@yelhousni yelhousni added type: bug Something isn't working type: cleanup labels Sep 10, 2024
Copy link
Copy Markdown
Collaborator

@ivokub ivokub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@gbotrel gbotrel merged commit e8cb61d into master Sep 10, 2024
@gbotrel gbotrel deleted the chore/up-gnark-crypto branch September 10, 2024 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type: bug Something isn't working type: cleanup

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants