fix: allow only v=0 or v=1#1293
Merged
Merged
Conversation
We followed the implementation of libsecp256k1 where v was allowed to be
{0,1,2,3}. However, EVM specification has restricted allowed v to be
only 0 or 1 for both transactions and precompiles.
Resolves LA audit issue F.
AlexandreBelling
approved these changes
Oct 10, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
We followed the implementation of libsecp256k1 where v was allowed to be {0,1,2,3}. However, EVM specification has restricted allowed v to be only 0 or 1 for both transactions and precompiles.
From Linea arithmetization POV shouldn't have been an issue as the arithmetization already constrains v to be 0 or 1 and doesn't pass inputs to gnark circuit when v is something else:

Resolves LA audit issue F.
Type of change
How has this been tested?
Existing tests pass.
Added:
How has this been benchmarked?
Not benchmarked, but should reduce a few constraints due to one less select and boolean check.
Checklist:
golangci-lintdoes not output errors locally