Skip to content

fix: typos in documentation files#1327

Merged
ivokub merged 7 commits into
Consensys:fix/typos-v0.12from
leopardracer:master
Nov 26, 2024
Merged

fix: typos in documentation files#1327
ivokub merged 7 commits into
Consensys:fix/typos-v0.12from
leopardracer:master

Conversation

@leopardracer
Copy link
Copy Markdown
Contributor

This pull request contains changes to improve clarity, correctness and structure.

Description correction:
Corrected finel to final
Corrected occurence to ccurrence
Corrected swith to switch
Corrected adjustement to adjustment
Corrected initialisation to initialization
Corrected compatiblity to compatibility
Corrected jacobain to jacobian
Releases , (extra space before the comma) — it should be releases,

Please review the changes and let me know if any additional changes are needed.

@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Nov 25, 2024

CLA assistant check
All committers have signed the CLA.

@ivokub
Copy link
Copy Markdown
Collaborator

ivokub commented Nov 26, 2024

Thanks for the contribution! However - CHANGELOG.md is automatically generated from the commits when we create next release and it would be overwritten at the next release. Could you revert the changes to the changelog?

Secondly - could you set the base branch to fix/typos-v0.12 branch? We're collecting typo fixes into a single branch which we would merge before the next release to avoid any potential merge conflicts.

@ivokub ivokub self-requested a review November 26, 2024 09:09
@ivokub ivokub added the type: typo Fixes typos in comments or documentation label Nov 26, 2024
@leopardracer leopardracer changed the base branch from master to fix/typos-v0.12 November 26, 2024 12:02
@leopardracer
Copy link
Copy Markdown
Contributor Author

leopardracer commented Nov 26, 2024

Hi @ivokub! I have checked and confirmed that there are no changes to the CHANGELOG.md file in this Pull Request. The base branch has now been set to fix/typos-v0.12. Please let me know if any further adjustments are needed. Thank you!
Can you confirm if everything has been done correctly?

This reverts commit aace233.
@ivokub ivokub merged commit 5c0e243 into Consensys:fix/typos-v0.12 Nov 26, 2024
@ivokub
Copy link
Copy Markdown
Collaborator

ivokub commented Nov 26, 2024

Thanks for addressing the issues! I reverted commit aace233 which reintroduced the typo you already fixed!

See #1325, I'll merge all different typo fixes before next release, which we anticipate within this year.

ivokub pushed a commit that referenced this pull request Dec 25, 2024
lucasmenendez pushed a commit to lucasmenendez/gnark that referenced this pull request Jan 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type: typo Fixes typos in comments or documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants