Skip to content

perf: normalize the random linear combination in logderivarg #1333

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ivokub merged 3 commits into from
Dec 2, 2024
Merged

perf: normalize the random linear combination in logderivarg #1333

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7ec03be
normalize the random linear combination in logderivarg
kustosz Nov 28, 2024
1feaa2d
Merge branch 'master' into logderiv-opt
kustosz Nov 28, 2024
ba30e89
Merge branch 'master' into logderiv-opt
kustosz Dec 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions std/internal/logderivarg/logderivarg.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,15 +147,13 @@ func Build(api frontend.API, table Table, queries Table) error {
}

func randLinearCoefficients(api frontend.API, nbRow int, commitment frontend.Variable) (rowCoeffs []frontend.Variable, challenge frontend.Variable) {
if nbRow == 1 {
return []frontend.Variable{1}, commitment
}
hasher, err := mimc.NewMiMC(api)
if err != nil {
panic(err)
}
rowCoeffs = make([]frontend.Variable, nbRow)
for i := 0; i < nbRow; i++ {
rowCoeffs[0] = 1
for i := 1; i < nbRow; i++ {
hasher.Reset()
hasher.Write(i+1, commitment)
rowCoeffs[i] = hasher.Sum()
Expand Down