fix: avoid linking icicle dependent files when tag not provided#1352
Merged
fix: avoid linking icicle dependent files when tag not provided#1352
Conversation
Co-authored-by: Ivo Kubjas <ivo.kubjas@consensys.net>
gbotrel
approved these changes
Dec 16, 2024
lucasmenendez
pushed a commit
to lucasmenendez/gnark
that referenced
this pull request
Jan 31, 2025
…ensys#1352) Co-authored-by: Jeremy Felder <jeremy.felder1@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Icicle depends on cgo and external dependencies which are not available for Mac/Windows and on machines when CUDA is not available. Also guard other methods behind build tag when it is not explicitly provided.
Checklist:
golangci-lintdoes not output errors locally