Skip to content

fix: avoid linking icicle dependent files when tag not provided#1352

Merged
ivokub merged 2 commits intomasterfrom
fix/noicicle
Dec 16, 2024
Merged

fix: avoid linking icicle dependent files when tag not provided#1352
ivokub merged 2 commits intomasterfrom
fix/noicicle

Conversation

@ivokub
Copy link
Copy Markdown
Collaborator

@ivokub ivokub commented Dec 16, 2024

Description

Icicle depends on cgo and external dependencies which are not available for Mac/Windows and on machines when CUDA is not available. Also guard other methods behind build tag when it is not explicitly provided.

Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I did not modify files generated from templates
  • golangci-lint does not output errors locally
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@ivokub ivokub added type: bug Something isn't working type: consolidate strengthen an existing feature labels Dec 16, 2024
@ivokub ivokub self-assigned this Dec 16, 2024
@ivokub ivokub requested a review from gbotrel December 16, 2024 11:23
@ivokub ivokub merged commit 627dc59 into master Dec 16, 2024
@ivokub ivokub deleted the fix/noicicle branch December 16, 2024 21:31
lucasmenendez pushed a commit to lucasmenendez/gnark that referenced this pull request Jan 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type: bug Something isn't working type: consolidate strengthen an existing feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants