feat: use OSS ICICLE for GPU acceleration (version v3.2.2)#1451
Merged
feat: use OSS ICICLE for GPU acceleration (version v3.2.2)#1451
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates the project to link against the OSS version of ICICLE (v3.2.2) for GPU acceleration. Key changes include updating the import paths from icicle/v3 to icicle-gnark/v3, modifying the device warmup logic to create and use a stream, and updating documentation links accordingly.
Reviewed Changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| backend/groth16/bn254/icicle/icicle.go | Updated ICICLE import paths to the new OSS repo |
| backend/groth16/bn254/icicle/device.go | Modified device warmup logic to incorporate stream creation |
| backend/backend.go | Updated documentation links to reflect new repo |
| README.md | Revised repository link for prerequisites |
| backend/groth16/bn254/icicle/provingkey.go | Updated core import path to use icicle-gnark |
Files not reviewed (1)
- go.mod: Language not supported
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Link against the OSS version of ICICLE. Also update some changed APIs
Type of change
How has this been tested?
Tested an example ECDSA circuit locally. It is not committed as we don't have GPU accelerated CI anyway and it requires a setup.
Checklist:
golangci-lintdoes not output errors locally