Skip to content

feat: emulated AssertIsDifferent#1479

Merged
yelhousni merged 2 commits into
masterfrom
feat/emu-assertIsDifferent
Apr 17, 2025
Merged

feat: emulated AssertIsDifferent#1479
yelhousni merged 2 commits into
masterfrom
feat/emu-assertIsDifferent

Conversation

@ivokub
Copy link
Copy Markdown
Collaborator

@ivokub ivokub commented Apr 16, 2025

Description

Even though we were able to assert emulated element difference previously quite easily, then add a dedicated method so that in case we have some optimizations in the future it could be applied automatically.

Type of change

  • New feature (non-breaking change which adds functionality)

How has this been tested?

  • TestAssertIsDifferent

Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I did not modify files generated from templates
  • golangci-lint does not output errors locally
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@ivokub ivokub requested a review from yelhousni April 16, 2025 16:05
@ivokub ivokub self-assigned this Apr 16, 2025
Copy link
Copy Markdown
Contributor

@yelhousni yelhousni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@yelhousni yelhousni merged commit fdeeb39 into master Apr 17, 2025
5 checks passed
@yelhousni yelhousni deleted the feat/emu-assertIsDifferent branch April 17, 2025 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants