Conversation
Contributor
|
LGTM! adding a comment is enough IMO for now, as anyway the GLV endomorphism used is only defined on the prime subgroups. For the generic case we can use |
yelhousni
approved these changes
May 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Notifies users that the scalar multiplication result is undefined in case the input point is not in the prime order subgroup.
Resolves #1484.
cc @yelhousni - right now I only added comments. But dunno if we would like to add an option which would enable using "naive scalar multiplication" for all points? I'm not sure if it would be necessary anywhere, but maybe could be useful?
Type of change
Checklist:
golangci-lintdoes not output errors locally