Skip to content

fix: range over all limbs in normalized form for lookup#1505

Merged
yelhousni merged 2 commits intomasterfrom
fix/lookup-limb-range
Jun 4, 2025
Merged

fix: range over all limbs in normalized form for lookup#1505
yelhousni merged 2 commits intomasterfrom
fix/lookup-limb-range

Conversation

@ivokub
Copy link
Copy Markdown
Collaborator

@ivokub ivokub commented Jun 3, 2025

Description

For non-native arithmetic Lookup2 and Mux we used Lookup2 and Mux on individual limbs. We normalized the inputs so that we would always have the same number of limbs, but when we did the final Lookup2/Mux, we only range over the number of limbs the first input had.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How has this been tested?

  • TestLookup2AndMuxOnAllLimbs

Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I did not modify files generated from templates
  • golangci-lint does not output errors locally
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@ivokub ivokub requested a review from yelhousni June 3, 2025 22:01
@ivokub ivokub self-assigned this Jun 3, 2025
@ivokub ivokub added the type: bug Something isn't working label Jun 3, 2025
Copy link
Copy Markdown
Contributor

@yelhousni yelhousni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch!

@yelhousni yelhousni merged commit e582692 into master Jun 4, 2025
6 checks passed
@yelhousni yelhousni deleted the fix/lookup-limb-range branch June 4, 2025 16:38
@ivokub ivokub mentioned this pull request Jun 4, 2025
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type: bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants