Skip to content

fix: enable fuzzing for multi-output-hint test by improving dvHint validation #1517

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ivokub merged 4 commits into from
Jun 23, 2025
Merged

fix: enable fuzzing for multi-output-hint test by improving dvHint validation #1517

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
118363e
fix(hint): add input validation to dvHint function
ruslan0012 Jun 19, 2025
31a7d45
test: enable fuzzing for multi-output-hint test
ruslan0012 Jun 19, 2025
ed17223
Merge branch 'master' into pr/ruslan0012/1517
ivokub Jun 23, 2025
a536736
chore: gofmt
ivokub Jun 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions integration_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,11 +44,6 @@ func TestIntegrationAPI(t *testing.T) {
opts = append(opts, test.WithInvalidAssignment(tData.InvalidAssignments[i]))
}

if name == "multi-output-hint" {
// TODO @gbotrel FIXME
opts = append(opts, test.NoFuzzing())
}

assert.CheckCircuit(tData.Circuit, opts...)
}, name)
}
Expand Down
13 changes: 13 additions & 0 deletions internal/backend/circuits/hint.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,8 +148,21 @@ var make3 = func(_ *big.Int, inputs []*big.Int, result []*big.Int) error {
}

var dvHint = func(_ *big.Int, inputs []*big.Int, res []*big.Int) error {
// Check that inputs and outputs have the same length
if len(inputs) != len(res) {
return fmt.Errorf("dvHint: expected same length for inputs and results, got %d inputs and %d results", len(inputs), len(res))
}

// Ensure we have at least one input to process
if len(inputs) == 0 {
return fmt.Errorf("dvHint: no inputs provided")
}

two := big.NewInt(2)
for i := range inputs {
if inputs[i] == nil {
return fmt.Errorf("dvHint: input at index %d is nil", i)
}
res[i].Mul(two, inputs[i])
}
return nil
Expand Down