Skip to content

Fix/xor cst var plonk#383

Merged
gbotrel merged 11 commits intodevelopfrom
fix/xor_cst_var_plonk
Oct 13, 2022
Merged

Fix/xor cst var plonk#383
gbotrel merged 11 commits intodevelopfrom
fix/xor_cst_var_plonk

Conversation

@ThomasPiellard
Copy link
Copy Markdown
Collaborator

@ThomasPiellard ThomasPiellard commented Oct 12, 2022

Changes:

  • Addition of tests for Xor( var, )
  • Simplified the writing of Xor in the r1cs API
  • Fixed the Xor in sparseR1cs when one of the operands is constant

in the reduce method of the r1cs, the terms multiplied by zeroes are removed:

	// if the coefficient is zero, we remove it
        if ccID == compiled.CoeffIdZero {
	        l = append(l[:i], l[i+1:]...)
	        continue
        }

@gbotrel gbotrel merged commit f489cc4 into develop Oct 13, 2022
@gbotrel gbotrel deleted the fix/xor_cst_var_plonk branch October 13, 2022 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants