Skip to content

fix: closes #509 api did not handle AssertIsLessOrEqual with constant as first param#511

Merged
gbotrel merged 3 commits intodevelopfrom
fix/issue509
Mar 2, 2023
Merged

fix: closes #509 api did not handle AssertIsLessOrEqual with constant as first param#511
gbotrel merged 3 commits intodevelopfrom
fix/issue509

Conversation

@gbotrel
Copy link
Copy Markdown
Collaborator

@gbotrel gbotrel commented Mar 1, 2023

No description provided.

@gbotrel gbotrel requested review from ThomasPiellard and ivokub March 1, 2023 21:20
@gbotrel gbotrel linked an issue Mar 1, 2023 that may be closed by this pull request
@akirillo
Copy link
Copy Markdown

akirillo commented Mar 1, 2023

dang you are fast dude

Copy link
Copy Markdown
Collaborator

@ivokub ivokub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I added a few comments about marking bits of decomposed values as boolean. It definitely doesn't hurt, but if the bits are not used, then the table of boolean variables gets bigger.

Copy link
Copy Markdown
Collaborator

@ivokub ivokub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes all good 👍

@gbotrel gbotrel merged commit 02f598e into develop Mar 2, 2023
@gbotrel gbotrel deleted the fix/issue509 branch March 2, 2023 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

AssertIsLessOrEqual panics when first argument is an int literal

3 participants