Closed
Conversation
This was referenced Mar 7, 2023
Merged
ivokub
approved these changes
Mar 7, 2023
Collaborator
ivokub
left a comment
ivokub
left a comment
There was a problem hiding this comment.
After rebasing on top of refactored algebra and gnark-crypto update, looks good. There are a few notes about nice-to-have element initialization methods.
Contributor
Author
|
Closing this PR as it is included in #566 with some added and modified tests there. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Needs Consensys/gnark-crypto#354 to be merged on gnark-crypto side