refactor: expose all typed backends in gnark/backend (moved from internal/)#561
Merged
Conversation
Collaborator
Author
|
Probably, the big ugly type switches we have in |
ivokub
approved these changes
Mar 14, 2023
Collaborator
ivokub
left a comment
ivokub
left a comment
There was a problem hiding this comment.
Two no-op duplicate directory make, but otherwise good.
| groth16Dir := filepath.Join(d.RootPath, "groth16") | ||
| plonkDir := filepath.Join(d.RootPath, "plonk") | ||
|
|
||
| if err := os.MkdirAll(groth16Dir, 0700); err != nil { |
|
|
||
| if err := os.MkdirAll(groth16Dir, 0700); err != nil { | ||
| panic(err) | ||
| } |
Collaborator
|
Now when the methods are not internal anymore it would be good if the package documentation would be a bit more thorough, but I would keep it as a future work as part of a bigger documentation overhaul. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Makes third party workflow and integration easier, for groth16 things are relatively stable now, may have couple of changes in PlonK in the future releases.