perf, feat: assert.CheckCircuit(...)

.github/parse-tests.js

@@ -0,0 +1,61 @@
+const readline = require("readline");
+
+const rl = readline.createInterface({
+  input: process.stdin,
+  output: process.stdout,
+  terminal: false,
+});
+
+const summary = { fail: [], pass: [], skip: [] };
+
+rl.on("line", (line) => {
+  const output = JSON.parse(line);
+  if (
+    output.Action === "pass" ||
+    output.Action === "skip" ||
+    output.Action === "fail"
+  ) {
+    if (output.Test) {
+      summary[output.Action].push(output);
+    }
+  }
+});
+
+
+rl.on("close", () => {
+  console.log("## Summary");
+  console.log("\n");
+  // console.log("| | # of Tests |");
+  // console.log("|--|--|");
+  console.log(
+    "✅ Passed:  %d",
+    summary.pass.length
+  );
+  console.log(
+    "❌ Failed: %d",
+    summary.fail.length
+  );
+  console.log(
+    "🚧 Skipped: %d",
+    summary.skip.length
+  );
+
+  if (summary.fail.length > 0) {
+    console.log("\n## ❌ Failures\n");
+  }
+
+  summary.fail.forEach((test) => {
+    console.log("* `%s` (%s)", test.Test, test.Package);
+  });
+
+  // also display skipped tests.
+  if (summary.skip.length > 0) {
+    console.log("\n## 🚧 Skipped\n");
+  }
+
+  summary.skip.forEach((test) => {
+    console.log("* `%s` (%s)", test.Test, test.Package);
+  });
+
+});
+

.github/workflows/pr.yml

@@ -2,26 +2,17 @@ on: pull_request
 name: pull_request
 jobs:
   staticcheck:
-    runs-on: ubuntu-latest
+    runs-on: ubuntu-22.04-16core
     steps:
-    - name: install Go
-      uses: actions/setup-go@v3
-      with:
-        go-version: 1.21.x
     - name: checkout code
-      uses: actions/checkout@v3
+      uses: actions/checkout@v4
       with:
         fetch-depth: 0
-    - uses: actions/cache@v3
+    - name: install Go
+      uses: actions/setup-go@v4
       with:
-        path: |
-          ~/go/pkg/mod
-          ~/.cache/go-build
-          ~/Library/Caches/go-build
-          %LocalAppData%\go-build
-        key: ${{ runner.os }}-go-${{ hashFiles('**/go.sum') }}
-        restore-keys: |
-          ${{ runner.os }}-go-
+        go-version: 1.21.x
+
     - name: install deps
       run: go install golang.org/x/tools/cmd/goimports@latest && go install github.com/klauspost/asmfmt/cmd/asmfmt@latest
     - name: gofmt
@@ -38,52 +29,60 @@ jobs:
       run: |
         find . -type f -name '*.go' -exec sed -i 's/Code generated by .* DO NOT EDIT/FOO/g' {} \;
       # on macos: find . -type f -name '*.go' -exec sed -i '' -E 's/Code generated by .* DO NOT EDIT/FOO/g' {} \;
-
     - name: golangci-lint
       uses: golangci/golangci-lint-action@v3
       with:
-          args: --timeout=5m
+          version: v1.54
+          args: -v --timeout=5m
+          skip-pkg-cache: true
 
   test:
-    strategy:
-      matrix:
-        go-version: [1.21.x]
-        os: [ubuntu-latest]
-    runs-on: ${{ matrix.os }}
+    runs-on: ubuntu-22.04-16core
     needs:
       - staticcheck
+    permissions: 
+      pull-requests: write
     steps:
-    - name: install Go
-      uses: actions/setup-go@v3
-      with:
-        go-version: ${{ matrix.go-version }}
     - name: checkout code
-      uses: actions/checkout@v3
-    - uses: actions/cache@v3
+      uses: actions/checkout@v4
+    - name: install Go
+      uses: actions/setup-go@v4
       with:
-        path: |
-          ~/go/pkg/mod
-          ~/.cache/go-build
-          ~/Library/Caches/go-build
-          %LocalAppData%\go-build
-        key: ${{ runner.os }}-go-${{ hashFiles('**/go.sum') }}
-        restore-keys: |
-          ${{ runner.os }}-go-
+        go-version: 1.21.x
+
     - name: install deps
       run: |
         go install golang.org/x/tools/cmd/goimports@latest && go install github.com/klauspost/asmfmt/cmd/asmfmt@latest
-        go install github.com/ethereum/go-ethereum/cmd/abigen@v1.12.0
         go install github.com/consensys/gnark-solidity-checker@latest
+        go install github.com/ethereum/go-ethereum/cmd/abigen@v1.12.0
         sudo add-apt-repository ppa:ethereum/ethereum
         sudo apt-get update
         sudo apt-get install solc
-    - name: Test
+
+    # Install gotestfmt on the VM running the action.
+    - name: Set up gotestfmt
+      uses: gotesttools/gotestfmt-action@v2
+      with:
+        # Optional: pass GITHUB_TOKEN to avoid rate limiting.
+        token: ${{ secrets.GITHUB_TOKEN }}
+
+    # Run tests with nice formatting. Save the original log in /tmp/gotest.log
+    - name: Run tests
       run: |
-        go test -v -short -tags=solccheck -timeout=30m ./...
-    - name: Test race
+        set -euo pipefail
+        go test -json -v -short -timeout=30m ./... 2>&1 | tee /tmp/gotest.log | gotestfmt
+        go test -json -v -tags=release_checks,solccheck . 2>&1 | tee -a /tmp/gotest.log | gotestfmt
+
+    - name: Generate job summary
       run: |
-        go test -v -short -race -timeout=50m
-
+        cat /tmp/gotest.log | node .github/parse-tests.js > /tmp/gotest.md
+        cat /tmp/gotest.md > $GITHUB_STEP_SUMMARY
+
+    - name: PR comment with file
+      uses: thollander/actions-comment-pull-request@v2
+      with:
+        filePath: /tmp/gotest.md
+
   slack-workflow-status-failed:
     if: failure()
     name: post workflow status to slack
@@ -94,7 +93,7 @@ jobs:
     steps:
       - name: Notify slack -- workflow failed
         id: slack
-        uses: slackapi/slack-github-action@v1.23.0
+        uses: slackapi/slack-github-action@v1.24.0
         with:
           payload: |
             {
@@ -118,7 +117,7 @@ jobs:
     steps:
       - name: Notify slack -- workflow succeeded
         id: slack
-        uses: slackapi/slack-github-action@v1.23.0
+        uses: slackapi/slack-github-action@v1.24.0
         with:
           payload: |
             {

.github/workflows/push.yml

@@ -2,31 +2,19 @@ on:
   push:
     branches:
       - 'master'
-      - 'develop'
-name: push_master_develop
+name: push_master
 jobs:
   staticcheck:
-    runs-on: ubuntu-latest
+    runs-on: ubuntu-22.04-16core
     steps:
-    - name: install Go
-      uses: actions/setup-go@v3
-      with:
-        go-version: 1.21.x
     - name: checkout code
-      uses: actions/checkout@v3
+      uses: actions/checkout@v4
       with:
         fetch-depth: 0
-    - uses: actions/cache@v3
+    - name: install Go
+      uses: actions/setup-go@v4
       with:
-        path: |
-          ~/go/pkg/mod
-          ~/.cache/go-build
-          ~/Library/Caches/go-build
-          %LocalAppData%\go-build
-        key: ${{ runner.os }}-go-${{ hashFiles('**/go.sum') }}
-        restore-keys: |
-          ${{ runner.os }}-go-
-
+        go-version: 1.21.x
 
     - name: install deps
       run: go install golang.org/x/tools/cmd/goimports@latest && go install github.com/klauspost/asmfmt/cmd/asmfmt@latest
@@ -44,38 +32,29 @@ jobs:
       run: |
         find . -type f -name '*.go' -exec sed -i 's/Code generated by .* DO NOT EDIT/FOO/g' {} \;
       # on macos: find . -type f -name '*.go' -exec sed -i '' -E 's/Code generated by .* DO NOT EDIT/FOO/g' {} \;
-
     - name: golangci-lint
       uses: golangci/golangci-lint-action@v3
       with:
-          args: --timeout=5m
-
+          version: v1.54
+          args: -v --timeout=5m
+          skip-pkg-cache: true
 
   test:
     strategy:
       matrix:
         go-version: [1.21.x]
-        os: [ubuntu-latest, windows-latest, macos-latest]
+        os: [ubuntu-22.04-16core, windows-latest, macos-latest]
     runs-on: ${{ matrix.os }}
     needs:
       - staticcheck
     steps:
+    - name: checkout code
+      uses: actions/checkout@v4
     - name: install Go
-      uses: actions/setup-go@v3
+      uses: actions/setup-go@v4
       with:
         go-version: ${{ matrix.go-version }}
-    - name: checkout code
-      uses: actions/checkout@v3
-    - uses: actions/cache@v3
-      with:
-        path: |
-          ~/go/pkg/mod
-          ~/.cache/go-build
-          ~/Library/Caches/go-build
-          %LocalAppData%\go-build
-        key: ${{ runner.os }}-go-${{ hashFiles('**/go.sum') }}
-        restore-keys: |
-          ${{ runner.os }}-go-
+
 
     - name: install deps
       run: |
@@ -88,18 +67,28 @@ jobs:
         sudo add-apt-repository ppa:ethereum/ethereum
         sudo apt-get update
         sudo apt-get install solc
+    # Install gotestfmt on the VM running the action.
+    - name: Set up gotestfmt
+      uses: gotesttools/gotestfmt-action@v2
+      with:
+        # Optional: pass GITHUB_TOKEN to avoid rate limiting.
+        token: ${{ secrets.GITHUB_TOKEN }}
     - name: Test (windows / mac)
       # on macOS CI / Windows CI we avoid running the std/ tests (they are run on ubuntu CI)
       if: matrix.os != 'ubuntu-latest'
       run: |
-        go test -v -timeout=60m .
-        go test -v -timeout=60m ./frontend/...
-        go test -v -timeout=60m ./backend/...
+        go test -json -tags=release_checks -v -timeout=60m . 2>&1 | tee /tmp/gotest.log | gotestfmt
+        go test -json -tags=release_checks -v -timeout=60m ./frontend/... 2>&1 | tee -a /tmp/gotest.log | gotestfmt
+        go test -json -tags=release_checks -v -timeout=60m ./backend/... 2>&1 | tee -a /tmp/gotest.log | gotestfmt
     - name: Test (race and solc)
       if: matrix.os == 'ubuntu-latest'
       run: |
-        go test -v -tags=solccheck ./...
-        go test -v -timeout=60m -race -short ./...
+        go test -json -v -timeout=60m -tags=release_checks ./... 2>&1 | tee -a /tmp/gotest.log | gotestfmt
+        go test -json -v -tags=release_checks,solccheck . 2>&1 | tee -a /tmp/gotest.log | gotestfmt
+        go test -json -v -timeout=60m -race -short ./... 2>&1 | tee -a /tmp/gotest.log | gotestfmt
+    - name: Generate job summary
+      run: |
+        cat /tmp/gotest.log | node .github/parse-tests.js > $GITHUB_STEP_SUMMARY
 
   slack-workflow-status-failed:
     if: failure()
@@ -111,7 +100,7 @@ jobs:
     steps:
       - name: Notify slack -- workflow failed
         id: slack
-        uses: slackapi/slack-github-action@v1.23.0
+        uses: slackapi/slack-github-action@v1.24.0
         with:
           payload: |
             {
@@ -135,7 +124,7 @@ jobs:
     steps:
       - name: Notify slack -- workflow succeeded
         id: slack
-        uses: slackapi/slack-github-action@v1.23.0
+        uses: slackapi/slack-github-action@v1.24.0
         with:
           payload: |
             {

.gotestfmt/downloads.gotpl

@@ -0,0 +1,39 @@
+{{- /*gotype: github.com/gotesttools/gotestfmt/v2/parser.Downloads*/ -}}
+{{- /*
+This template contains the format for a package download.
+*/ -}}
+{{- $settings := .Settings -}}
+{{- if or .Packages .Reason -}}
+    {{- if or (not .Settings.HideSuccessfulDownloads) .Failed -}}
+        ::group::
+        {{- if .Failed -}}
+            {{ "\033" }}[0;31m❌
+        {{- else -}}
+            {{ "\033" }}[0;34m📥
+        {{- end -}}
+        {{ " " }}Dependency downloads
+        {{- "\033" }}[0m{{ "\n" -}}
+
+        {{- range .Packages -}}
+            {{- if or (not $settings.HideSuccessfulDownloads) .Failed -}}
+                {{- "   " -}}
+                {{- if .Failed -}}
+                    {{ "\033" }}[0;31m❌
+                {{- else -}}
+                    📦
+                {{- end -}}
+                {{- " " -}}
+                {{- .Package }} {{ .Version -}}
+                {{- "\033" }}[0m
+                {{- "\n" -}}
+                {{ with .Reason -}}
+                    {{- "     " -}}{{ . -}}{{ "\n" -}}
+                {{- end -}}
+            {{- end -}}
+        {{- end -}}
+        {{- with .Reason -}}
+        {{- "   " -}}{{- "\033" }}[0;31m🛑 {{ . }}{{- "\033" }}[0m{{ "\n" -}}
+        {{- end -}}
+        ::endgroup::
+    {{- end -}}
+{{- end -}}