Skip to content

feat: add short-hash wrappers for recursion#884

Merged
ivokub merged 1 commit intomasterfrom
feat/mismatch-hash
Oct 25, 2023
Merged

feat: add short-hash wrappers for recursion#884
ivokub merged 1 commit intomasterfrom
feat/mismatch-hash

Conversation

@ivokub
Copy link
Copy Markdown
Collaborator

@ivokub ivokub commented Oct 23, 2023

Description

This PR adds hash function wrappers which allow to hash elements in the current field and return an output in the target field. If necessary, we cut the excess bits. We add both native and in-circuit implementation so that we can compute recursive proofs and verify in-circuit.

Related #848. I think this PR is sufficient for recursion purporses.

Subtask of #847 and related to PR #880 (cherry picked from).

Type of change

  • New feature (non-breaking change which adds functionality)

How has this been tested?

  • Added unit tests for all supported curves

How has this been benchmarked?

Not benchmarked.

Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I did not modify files generated from templates
  • golangci-lint does not output errors locally
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@ivokub ivokub added type: new feature type: consolidate strengthen an existing feature dep: linea Issues affecting Linea downstream priority: P1-high Issue priority: high labels Oct 23, 2023
@ivokub ivokub requested a review from ThomasPiellard October 23, 2023 10:14
@ivokub ivokub self-assigned this Oct 23, 2023
@ivokub ivokub marked this pull request as draft October 23, 2023 11:20
@ivokub ivokub force-pushed the feat/mismatch-hash branch from 72d5d8e to c99c6f5 Compare October 25, 2023 00:42
@ivokub ivokub marked this pull request as ready for review October 25, 2023 00:49
@ivokub ivokub merged commit d051aa9 into master Oct 25, 2023
@ivokub ivokub deleted the feat/mismatch-hash branch October 25, 2023 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dep: linea Issues affecting Linea downstream priority: P1-high Issue priority: high type: consolidate strengthen an existing feature type: new feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants