Fixed and tested the whitespace issue in directory paths on Windows, resolved the comparison operator bug, and removed unused variables from mkconcore.py. #129
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Hey @pradeeban sir, please let me know which issue I can work on next if the issues I addressed are going to be merged. Also, let me know if you need any changes in this PR. |
Member
|
Thanks for your contributions. I am merging it. Next time, please create separate PRs to resolve separate issues. (I know these are relatively smaller fixes. but always nice to separate. That way, easy to merge one-by-one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed #126 , #127 , #123 In This PR
#126 is solved in makestudy.bat (Fixed and tested the whitespace issue in directory paths on Windows)
#127 is solved in makestudy (resolved the comparison operator and Command Substitution bug)
#123 is done in mkconcore.py (removed unused variables from mkconcore.py)
All These Are Tested From My End