Skip to content

Fix cosmwasm-vm tests on windows#1369

Closed
devashishdxt wants to merge 1 commit intoCosmWasm:mainfrom
devashishdxt:windows-tests
Closed

Fix cosmwasm-vm tests on windows#1369
devashishdxt wants to merge 1 commit intoCosmWasm:mainfrom
devashishdxt:windows-tests

Conversation

@devashishdxt
Copy link
Copy Markdown

There are 2 major changes:

  • Created windows symlinks for wasm files as windows does not recognize linux symlinks.
  • Windows returns different error message when file not found.

@@ -523,8 +536,21 @@ mod tests {

match cache.load_wasm(&checksum).unwrap_err() {
VmError::CacheErr { msg, .. } => {
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@webmaster128
Copy link
Copy Markdown
Member

Thank you for bringing this up. I'm not sure if developing cosmwasm-vm on Windows is in scope. So far we only supported contract development on Windows. But even if we don't support development on Windows, we should be able to run the tests if we want to support libwasmvm on Windows.

The error message thing can be fixed one way or another. But not being able to use symlinks is bad. But it seems like this problem is solved: https://stackoverflow.com/questions/5917249/git-symbolic-links-in-windows/59761201#59761201

@webmaster128
Copy link
Copy Markdown
Member

webmaster128 commented Aug 30, 2022

May I invite you to have a look at #1406 and check if this passes on Windows?

@webmaster128
Copy link
Copy Markdown
Member

Created windows symlinks for wasm files as windows does not recognize linux symlinks.

#1499 shows a CI integration which enables symlinks on Windows. So we can just use them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants