Switch MetricsSourceGenerator to IIncrementalGenerator#817
Merged
Conversation
…1035/RS1042 suppressions Co-authored-by: einari <134365+einari@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Switch to using IIncrementalGenerator for MetricsSourceGenerator
Switch MetricsSourceGenerator to IIncrementalGenerator
Dec 21, 2025
Contributor
|
NuGet packages for this PR, e.g. Cratis: |
1 similar comment
Contributor
|
NuGet packages for this PR, e.g. Cratis: |
Contributor
|
NuGet packages for this PR, e.g. Cratis: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changed
MetricsSourceGeneratorfromISourceGeneratortoIIncrementalGeneratorto follow current Roslyn best practices and eliminate analyzer warnings RS1035 and RS1042ISyntaxReceiverpattern with incremental pipeline usingCreateSyntaxProviderfor syntax filtering andRegisterSourceOutputfor code generationSourceProductionContextinstead ofGeneratorExecutionContextRemoved
MetricsSyntaxReceiver.cs- filtering logic now integrated directly into generator using static predicatesdotnet_diagnostic.RS1035.severity = noneanddotnet_diagnostic.RS1042.severity = nonesuppressions from.globalconfigBenefits: The incremental generator only re-runs on changed files rather than the entire compilation, improving build performance. The pipeline properly caches intermediate results and supports parallel execution.
Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.