Skip to content

feat: Don't snapshot working copy when getting diff#114

Merged
Cretezy merged 1 commit intomainfrom
push-ynurlqqnvzuy
Mar 2, 2025
Merged

feat: Don't snapshot working copy when getting diff#114
Cretezy merged 1 commit intomainfrom
push-ynurlqqnvzuy

Conversation

@Cretezy
Copy link
Owner

@Cretezy Cretezy commented Mar 2, 2025

More performance optimizations

@Cretezy Cretezy force-pushed the push-ynurlqqnvzuy branch from 53738dd to c6c1655 Compare March 2, 2025 20:20
@istudyatuni
Copy link
Collaborator

It's seems better, but sometimes still very long. I tracked it down to #102

@Cretezy
Copy link
Owner Author

Cretezy commented Mar 2, 2025

@istudyatuni Ah, that makes sense. Performance is dependent on the performance of the diff tool. What tool are you using?

The fix for this would be using a faster diff tool or setting lazyjj.diff-format = "color-words" unfortunately. Unless we want to do an async/multi-thread architecture where data can be fetched and rendered separately.

@istudyatuni
Copy link
Collaborator

Oh, I forgot about it, thanks for pointing out!

@Cretezy Cretezy merged commit 69f3884 into main Mar 2, 2025
10 checks passed
@Cretezy Cretezy deleted the push-ynurlqqnvzuy branch March 2, 2025 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants