Merged
Conversation
We don't explicitly hide the cursor, so we don't have to show it either.
The way the code is written, it's enforced by the type system, that the backend uses Stdout, so we can just use Stdout directly. This makes it easier to call restore_terminal() from other places, like e.g. a panic handler to restore the terminal on panics and not leave the terminal garbled and in a messed up state.
Otherwise, the terminal is left all messed up on panics.
Collaborator
|
See also #75 Though I think your solution is good for handling unexpected panics |
Collaborator
Author
|
Yeah, this is orthogonal to your PR. I'm regularly experiencing panics after e.g. |
Collaborator
Cretezy
approved these changes
Feb 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.