Skip to content

Conversation

@vitorespindola
Copy link
Contributor

@vitorespindola vitorespindola commented Mar 30, 2020

This will fix #28

I'm not a Go developer and maybe this is not the right approach on this error, but this fixed my issue.


This change is Reviewable

Copy link
Member

@Ulexus Ulexus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @vitorespindola)

a discussion (no related file):
There's nothing wrong with the nil check, but I would like to know the scenario in which this occurs. e.Keys() should not be returning nil items in the set.

I'd like to know what is causing that in order to fix it, too.


Copy link
Member

@Ulexus Ulexus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @vitorespindola)

Copy link
Member

@Ulexus Ulexus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

Copy link
Member

@Ulexus Ulexus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r2.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@Ulexus Ulexus merged commit 1aeff2a into CyCoreSystems:master Mar 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Runtime error using NATS client without go ARI package

2 participants