more explicit build dependency handling#755
Conversation
cdaa4f0 to
600951e
Compare
Shnatsel
left a comment
There was a problem hiding this comment.
I believe I have found a bug, please check the review comments.
|
I retract what I said about resolver v2 - we cannot fix that edge case because Please fix the test failures and I'll be happy to merge this. |
0781d17 to
0e6cec6
Compare
Signed-off-by: Markus Theil <theil.markus@gmail.com>
Signed-off-by: Markus Theil <theil.markus@gmail.com>
Signed-off-by: Markus Theil <theil.markus@gmail.com>
Signed-off-by: Markus Theil <theil.markus@gmail.com>
0e6cec6 to
52a8170
Compare
|
@Shnatsel ready & thanks for your feedback regarding resolver v2. |
|
Thank you, I will take a look in the next few days. My revised feedback about resolver v2 is to ignore its existence. I am really sorry about sending you on this wild goose chase. I forgot that Cargo just does not expose enough data for us to handle this correctly. |
|
I'm going to go ahead and merge this to expedite the process. What nits I have I'll address myself in a follow-up PR. Thank you! |
This is a follow up on #736 which was merged and later reverted because of a infinite loop I accidentally produced there.
This PR differs in the following: