Merged
Conversation
Chrisschmit
requested changes
Apr 22, 2025
Collaborator
Chrisschmit
left a comment
Chrisschmit
left a comment
There was a problem hiding this comment.
Left some comments :)
| params: dict[str, int] = None, | ||
| num: int = 1): | ||
| num: int = 1, | ||
| names: list[str] = None): |
Collaborator
There was a problem hiding this comment.
nit: add explicit typing:
params: Optional[dict[str, int]] = None,
names: Optional[list[str]] = None
Collaborator
Author
There was a problem hiding this comment.
do you recommend doing this with the "from typing import Optional" class? I'm not used to declaring typing with optional, and am getting "Call expression not allowed in type expressionPylancereportInvalidTypeForm" when doing it naively.
| def add_generators(self, | ||
| num: int = 1, | ||
| gen_type: str = "small", | ||
| params: dict[str, int] = None, |
Collaborator
There was a problem hiding this comment.
nit add typing same as above
sarahmish
reviewed
Apr 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow "nicknames" of nodes - users can assign them abbreviated names that they can later reference when making lines, specifying loads to add pv system to, etc.
Added test in accordance with error handling