Conversation
* previous changes in SUI-1547 brought to attention that SearchResultEntry should not be used in version 2 HTTP results, it should use SearchResultItem like version 1, which also fixes some SQ/code-analysis warnings * noticed that `usePolling` in the e2e tests could be removed from various places because its used less due to previous refactor * some other existing null ref / init warnings
Collaborator
robshakespeare
left a comment
robshakespeare
left a comment
There was a problem hiding this comment.
Very nicely done, thank you.
Just waiting on the stubs update now, then we can get a full e2e test of the polling 👍 🙂
…cate file in find/tests
* Fixed: Missing DI registration * Fixed: Content type issue, and added missing /api/ URL prefix * Fixed: Queue not found issue
…b, so we need to get a distinct count of completed jobs from the records when calculating the completeness percentage
…sion 1 and version 2
…ng implementation
… more time to complete
# Conflicts: # Apps/Find/tests/SUI.Find.Infrastructure.UnitTests/Services/JobSearchServiceTests.cs
…it was incorrectly 200 even for 401 Unauthorized)
…o run on HTTP or HTTPS when running locally and in the pipeline (ephemeral)
…ecause it is inherently slower
…te the completeness percentage.
# Conflicts: # Apps/Find/src/SUI.Find.Infrastructure/Handlers/JobResultHandler.cs
![github-code-quality[bot]](https://avatars.githubusercontent.com/u/9919?s=60&v=4){kind=small}
Apps/Find/src/SUI.Find.Infrastructure/Services/JobSearchService.cs
Dismissed
Show dismissed
Hide dismissed
|
SummarySummary
CoverageSUI.Find.Application - 91.1%
SUI.Find.AuditProcessor - 11.2%
SUI.Find.Domain - 89.9%
SUI.Find.FindApi - 67.8%
SUI.Find.Infrastructure - 92.5%
|
robshakespeare
approved these changes
Apr 2, 2026
Collaborator
robshakespeare
left a comment
robshakespeare
left a comment
There was a problem hiding this comment.
Version 2 end-to-end test now passing 🚀
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.