Skip to content

chore: SUI-1647 - logger verifications#557

Merged
robshakespeare merged 4 commits intomainfrom
logger-verifications
Apr 2, 2026
Merged

chore: SUI-1647 - logger verifications#557
robshakespeare merged 4 commits intomainfrom
logger-verifications

Conversation

@robshakespeare
Copy link
Copy Markdown
Collaborator

@robshakespeare robshakespeare commented Apr 2, 2026 •
edited
Loading

It has been discovered that ReceivedWithAnyArgs does not behave as expected. NSubstitute only checks it has received the following call with any arguments (so the arguments specified are essentially ignored by ReceivedWithAnyArgs).

The updates here change the existing ReceivedWithAnyArgs assertions to verify the call and the explicitly specified arguments.

@robshakespeare
chore: small update, pass cancellationToken
693129c
@robshakespeare
chore: SUI-1647 - update mock logger assertions
5941304 
It has been discovered that ReceivedWithAnyArgs does not behave as expected.  NSubstitute only checks it has received the following call with any arguments (so the arguments specified are essentially ignored by ReceivedWithAnyArgs).

The updates here change the existing ReceivedWithAnyArgs assertions to verify the call and the explicitly specified arguments.
@robshakespeare robshakespeare enabled auto-merge (squash) April 2, 2026 15:51
@robshakespeare robshakespeare disabled auto-merge April 2, 2026 16:08
@robshakespeare robshakespeare enabled auto-merge (squash) April 2, 2026 16:09
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Apr 2, 2026

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 2, 2026

Summary

Summary
Generated on: 04/02/2026 - 16:10:45
Coverage date: 04/02/2026 - 16:10:33 - 04/02/2026 - 16:10:44
Parser: MultiReport (8x Cobertura)
Assemblies: 5
Classes: 112
Files: 100
Line coverage: 82% (4555 of 5550)
Covered lines: 4555
Uncovered lines: 995
Coverable lines: 5550
Total lines: 9320
Branch coverage: 74.4% (834 of 1120)
Covered branches: 834
Total branches: 1120
Method coverage: Feature is only available for sponsors

Coverage

SUI.Find.Application - 91.1%
Name Line Branch
SUI.Find.Application 91.1% 76.5%
SUI.Find.Application.Constants.Matching.MatchScoreConstants 0%
SUI.Find.Application.Extensions.LoggerActivityExtensions 96.5% 66.6%
SUI.Find.Application.Extensions.OrchestratorRuntimeStatusExtensions 72.7% 37.5%
SUI.Find.Application.Factories.PdsSearch.PdsSearchFactory 100% 100%
SUI.Find.Application.Models.AuditPayloads.PepFetchPayload 100% 100%
SUI.Find.Application.Models.CustodianSearchResultItem 100%
SUI.Find.Application.Models.Fhir.SearchQuery 76.4% 83.3%
SUI.Find.Application.Models.Fhir.SearchResult 100%
SUI.Find.Application.Models.JobResultRecord 100% 50%
SUI.Find.Application.Models.Matching.EncryptedSuidPersonId 100%
SUI.Find.Application.Models.Matching.MatchResult 86.1% 77.7%
SUI.Find.Application.Models.Matching.Metadata 100% 100%
SUI.Find.Application.Models.Matching.PlainPersonId 100%
SUI.Find.Application.Models.SearchResultItem 100% 100%
SUI.Find.Application.Services.FetchRecordService 94.1% 90.5%
SUI.Find.Application.Services.MaskUrlService 100% 100%
SUI.Find.Application.Services.Matching.MatchingEncryptionService 86.6% 71.4%
SUI.Find.Application.Services.Matching.MatchingService 97.8% 88.2%
SUI.Find.Application.Services.MatchPersonOrchestrationService 92.1% 81.2%
SUI.Find.Application.Services.PdsSearch.PdsSearchV1 91.6%
SUI.Find.Application.Services.PdsSearch.SearchQueryBuilder 88.7% 56.2%
SUI.Find.Application.Services.PolicyEnforcementService 92.5% 80.5%
SUI.Find.Application.Services.QueryProvidersService 100% 100%
SUI.Find.Application.Services.SearchResultsService 87% 50%
SUI.Find.Application.Services.SearchService 95.8% 85.1%
SUI.Find.Application.Validation.Matching.PersonDataQualityTranslator 100% 95.1%
SUI.Find.Application.Validation.Matching.PersonSpecificationValidation 98.3% 50%
System.Text.RegularExpressions.Generated 73.3% 50%
System.Text.RegularExpressions.Generated.<RegexGenerator_g>F900DA481A13958B
0FDD243B6774DF288C2EB2558EB4EA05262827D57F2E697FC__CommonPhoneSeparatorRege
x_1		 75% 66.6%
System.Text.RegularExpressions.Generated.<RegexGenerator_g>F900DA481A13958B
0FDD243B6774DF288C2EB2558EB4EA05262827D57F2E697FC__FindWhiteSpaceRegex_0		 83.9% 66.6%
SUI.Find.AuditProcessor - 11.2%
Name Line Branch
SUI.Find.AuditProcessor 11.2% 0%
SUI.Find.AuditProcessor.DirectFunctionExecutor 0% 0%
SUI.Find.AuditProcessor.FunctionExecutorAutoStartup 0%
SUI.Find.AuditProcessor.FunctionExecutorHostBuilderExtensions 0%
SUI.Find.AuditProcessor.FunctionMetadataProviderAutoStartup 0%
SUI.Find.AuditProcessor.Functions.QueueAuditAccessTrigger 100%
SUI.Find.AuditProcessor.GeneratedFunctionMetadataProvider 0%
SUI.Find.AuditProcessor.WorkerHostBuilderFunctionMetadataProviderExtension 0%
SUI.Find.Domain - 89.9%
Name Line Branch
SUI.Find.Domain 89.9% 75.8%
SUI.Find.Domain.Models.Result`1 100%
SUI.Find.Domain.ValueObjects.NhsPersonId 96.7% 93.7%
System.Text.RegularExpressions.Generated 87.7% 68.1%
System.Text.RegularExpressions.Generated.<RegexGenerator_g>FAE7CDE050693992
3591B09121AF1D5EBB44979EA3F13DA1D404A81D1B688E40F__Base64UrlRegex_0		 87% 70%
SUI.Find.FindApi - 67.8%
Name Line Branch
SUI.Find.FindApi 67.8% 65.4%
SUI.Find.FindApi.DirectFunctionExecutor 0% 0%
SUI.Find.FindApi.FunctionExecutorAutoStartup 0%
SUI.Find.FindApi.FunctionExecutorHostBuilderExtensions 0%
SUI.Find.FindApi.FunctionMetadataProviderAutoStartup 0%
SUI.Find.FindApi.Functions.ActivityFunctions.AuditPepFindActivity 100% 75%
SUI.Find.FindApi.Functions.ActivityFunctions.FilterResultsByPolicyFunction 0%
SUI.Find.FindApi.Functions.ActivityFunctions.GetProvidersFunction 100%
SUI.Find.FindApi.Functions.ActivityFunctions.PersistSearchResultsFunction 100%
SUI.Find.FindApi.Functions.ActivityFunctions.QueryProvidersFunction 88.8% 66.6%
SUI.Find.FindApi.Functions.HttpFunctions.AuthTokenFunction 92.3% 73.9%
SUI.Find.FindApi.Functions.HttpFunctions.CancelSearchFunction 100% 100%
SUI.Find.FindApi.Functions.HttpFunctions.ClaimJobFunction 100% 91.6%
SUI.Find.FindApi.Functions.HttpFunctions.FetchRecordFunction 100% 100%
SUI.Find.FindApi.Functions.HttpFunctions.MatchFunction 88.3% 88.4%
SUI.Find.FindApi.Functions.HttpFunctions.SearchFunction 93.4% 57.1%
SUI.Find.FindApi.Functions.HttpFunctions.SearchFunctionV2 100% 76.9%
SUI.Find.FindApi.Functions.HttpFunctions.SearchResultsFunction 100% 100%
SUI.Find.FindApi.Functions.HttpFunctions.SearchResultsV2Function 100% 90%
SUI.Find.FindApi.Functions.HttpFunctions.SearchStatusFunction 100% 100%
SUI.Find.FindApi.Functions.HttpFunctions.SubmitJobResultsFunction 97.7% 83.3%
SUI.Find.FindApi.Functions.HttpFunctions.WorkAvailableFunction 100% 90%
SUI.Find.FindApi.Functions.OrchestratorFunctions.SearchOrchestrator 100% 100%
SUI.Find.FindApi.Functions.QueueFunctions.JobResultHandlerFunction 100% 75%
SUI.Find.FindApi.Functions.QueueFunctions.QueueSearchJobTrigger 100% 83.3%
SUI.Find.FindApi.Functions.TimerFunctions.ClearDataFunction 81.1% 66.6%
SUI.Find.FindApi.GeneratedFunctionMetadataProvider 0%
SUI.Find.FindApi.Models.SearchJob 100%
SUI.Find.FindApi.Models.SearchJobV2 100%
SUI.Find.FindApi.Models.SearchResults 100%
SUI.Find.FindApi.Models.SearchResultsV2 100%
SUI.Find.FindApi.Utility.HttpResponseUtility 100%
SUI.Find.FindApi.Validators.StartSearchRequestValidator 90.9% 83.3%
SUI.Find.FindApi.WorkerExtensionStartupCodeExecutor 0%
SUI.Find.FindApi.WorkerHostBuilderFunctionMetadataProviderExtension 0%
SUI.Find.Infrastructure - 92.5%
Name Line Branch
SUI.Find.Infrastructure 92.5% 80.7%
SUI.Find.Infrastructure.Clients.AuditQueueClient 100%
SUI.Find.Infrastructure.Clients.JobResultsQueueClient 100%
SUI.Find.Infrastructure.Configuration.JobClaimConfig 100%
SUI.Find.Infrastructure.Extensions.HostApplicationBuilderOpenTelemetryExten
sions		 89.7% 87.5%
SUI.Find.Infrastructure.Factories.Fhir.SearchParamsFactory 57.1% 8.3%
SUI.Find.Infrastructure.Handlers.JobResultHandler 94.5% 91.6%
SUI.Find.Infrastructure.Models.CachedToken 100% 50%
SUI.Find.Infrastructure.Repositories.JobRepository.JobKeys 100%
SUI.Find.Infrastructure.Repositories.JobRepository.JobRepository 91.6% 100%
SUI.Find.Infrastructure.Repositories.SearchResultEntryStorage.SearchResultE
ntryKeys		 100% 50%
SUI.Find.Infrastructure.Repositories.SearchResultEntryStorage.SearchResultE
ntryRepository		 80.2% 100%
SUI.Find.Infrastructure.Repositories.SuiCustodianRegister.RegisterKeys 100%
SUI.Find.Infrastructure.Repositories.SuiCustodianRegister.SuiCustodianRegis
terRepository		 90% 100%
SUI.Find.Infrastructure.Repositories.WorkItemJobCountRepository.WorkItemJob
Count		 100%
SUI.Find.Infrastructure.Repositories.WorkItemJobCountRepository.WorkItemJob
CountKeys		 100%
SUI.Find.Infrastructure.Repositories.WorkItemJobCountRepository.WorkItemJob
CountRepository		 100% 100%
SUI.Find.Infrastructure.Services.AuditStorageTableService 100%
SUI.Find.Infrastructure.Services.AzureKeyVaultSecretService 0%
SUI.Find.Infrastructure.Services.BuildCustodianRequestsService 100% 83.3%
SUI.Find.Infrastructure.Services.Fhir.FhirAuthTokenService 89.9% 70.8%
SUI.Find.Infrastructure.Services.Fhir.FhirService 97.7% 75%
SUI.Find.Infrastructure.Services.HashService 100% 100%
SUI.Find.Infrastructure.Services.JobClaimService 100% 81.8%
SUI.Find.Infrastructure.Services.JobProcessorService 100% 93.7%
SUI.Find.Infrastructure.Services.JobQueueService 100% 100%
SUI.Find.Infrastructure.Services.JobSearchService 100% 87.5%
SUI.Find.Infrastructure.Services.JobWindowStartService 100%
SUI.Find.Infrastructure.Services.JwtTokenService 100% 50%
SUI.Find.Infrastructure.Services.MockAuthStoreService 68.5% 50%
SUI.Find.Infrastructure.Services.MockCustodianService 98.1% 81.2%
SUI.Find.Infrastructure.Services.MockMatchRepository 100% 90%
SUI.Find.Infrastructure.Services.OutboundAuthService 90.1% 81.2%
SUI.Find.Infrastructure.Services.PersonIdEncryptionService 75.4% 83.3%
SUI.Find.Infrastructure.Services.UrlStorageTableService 100% 100%
SUI.Find.Infrastructure.TableKeyNormaliser 100% 100%
SUI.Find.Infrastructure.Utility.BuildCustodianHttpRequest 100% 90.9%
SUI.Find.Infrastructure.Utility.ProviderHttpClient 74.1% 100%

udara-jay
udara-jay approved these changes Apr 2, 2026
View reviewed changes
Copy link
Copy Markdown
Collaborator

@udara-jay udara-jay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great 👍

@robshakespeare robshakespeare merged commit 1f7d6a1 into main Apr 2, 2026
12 checks passed
@robshakespeare robshakespeare deleted the logger-verifications branch April 2, 2026 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@udara-jay udara-jay udara-jay approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@robshakespeare @udara-jay