Split up 2d and 3d flexible geometry#569
Merged
ecomodeller merged 35 commits intomainfrom Jun 8, 2023
Merged
Conversation
Member
Author
|
A 3d geometry is still fairly complex,, but that is expected, but a 2d geometry is now easier to understand. |
Member
Author
|
Current state of FM geometries classDiagram
class _Geometry{
+projection
}
class _GeometryFM{
+node_coordinates
+element_table
}
class GeometryFM2D{
+interp2d()
+get_element_area()
}
class _GeometryFMLayered{
- _n_layers
- _n_sigma
+ to_2d_geometry()
}
class GeometryFM3D{
+ plot()
+ boundary_polylines()
+ find_index()
}
class GeometryFMVerticalProfile{
+plot()
+ find_index()
}
_Geometry <|-- GeometryFMPointSpectrum
_Geometry <|-- _GeometryFM
_GeometryFM <|-- GeometryFM2D
GeometryFM2D <|-- _GeometryFMSpectrum
_GeometryFMSpectrum <|-- GeometryFMAreaSpectrum
_GeometryFMSpectrum <|-- GeometryFMLineSpectrum
_GeometryFM <|-- _GeometryFMLayered
_GeometryFMLayered <|-- GeometryFM3D
_GeometryFMLayered <|-- GeometryFMVerticalProfile
GeometryFM3D <|-- GeometryFMVerticalColumn
Not entirely sure what the |
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


No description provided.