ADR-009: No generic DataArray[T]/Dataset[T]#950
Open
ecomodeller wants to merge 1 commit into
Open
Conversation
Record the analysis of making DataArray and Dataset generic over geometry type T, and why the complexity outweighs the benefits.
Member
Author
|
Merge #949 first |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Documents the decision not to make
DataArrayandDatasetgeneric over geometry typeT.The generic type parameter would only be useful in the narrow window between reading a file and the first spatial operation (
isel/sel/aggregation), since those operations change the geometry type at runtime. Making the type parameter useful beyond that would require either complex overload chains or changingisel/selsemantics to preserve geometry type — both of which add complexity that serves the type system rather than the user.