Improve concat: test coverage, duplicate timestamp validation, match/case#957
Open
ecomodeller wants to merge 2 commits intomainfrom
Open
Improve concat: test coverage, duplicate timestamp validation, match/case#957ecomodeller wants to merge 2 commits intomainfrom
ecomodeller wants to merge 2 commits intomainfrom
Conversation
Addresses #956 — the concat logic is correct but requires chronologically sorted input. Added tests verifying overlap values for both keep modes, including an integration test using glob + sorted to match the reported workflow.
- Reject datasets with duplicate timestamps (e.g. DA diagnostic output) with a clear error instead of cryptic pandas reindex failure - Use match/case for keep parameter to catch invalid values - Remove dead hasattr/time check and stale comments
ecomodeller
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
keep='first'andkeep='last'ingeneric.concatwith dfs0 filessorted(glob(...))to reproduce the #956 workflowcannot reindex on an axis with duplicate labelsmatch/casefor thekeepparameter to catch invalid values like typoshasattr(self, "time")check and stale commentsThe concat logic is correct —
glob()returns files in arbitrary order, which is the likely root cause of #956. The workaround issorted(glob(...)).Closes #956