Comparer internal data structure as xarray Dataset#172
Merged
jsmariegaard merged 38 commits intomainfrom Mar 24, 2023
Merged
Conversation
ecomodeller
approved these changes
Mar 24, 2023
Member
ecomodeller
left a comment
ecomodeller
left a comment
There was a problem hiding this comment.
Changes in this PR ✅
But we are not done, there is still some untested functionality and optimal handling of empty collections to be considered🤔
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The purpose of this PR is to replace the internal data structure of the Comparer. It should have a single data attribute: an xarray Dataset. This dataset should completely define the Comparer allowing for easier filtering and persistence to disk.