Skip to content

Remove explicit geometry check #190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ecomodeller merged 4 commits into from
Jun 8, 2023
Merged

Remove explicit geometry check #190

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
648500d
Remove explicit geometry check
ecomodeller May 3, 2023
4f2634b
Merge branch 'main' into mikeio
ecomodeller May 20, 2023
6fd8319
load
ecomodeller May 22, 2023
7a86a73
Merge branch 'main' into mikeio
ecomodeller Jun 8, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions modelskill/model/dfsu.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,8 +36,10 @@ def __init__(
data = mikeio.open(data)

elif isinstance(data, (mikeio.DataArray, mikeio.Dataset)):
if not isinstance(data.geometry, mikeio.spatial.FM_geometry.GeometryFM):
raise ValueError(f"Geometry of {type(data)} is not supported.")
pass
# we could check that geometry has FM in the name, but ideally we would like to support more or all geometries
# if not "FM" in str(type(data.geometry)):
# raise ValueError(f"Geometry of {type(data.geometry)} is not supported.")
else:
raise ValueError(
f"data type must be .dfsu or dfsu-Dataset/DataArray. Not {type(data)}."
Expand Down
2 changes: 1 addition & 1 deletion modelskill/plot.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -439,7 +439,7 @@ def scatter(


def plot_observation_positions(
geometry: mikeio.spatial.FM_geometry.GeometryFM,
geometry,
observations: List[Observation],
figsize: Tuple = None,
title=None,
Expand Down