move from_matched and compare to new module#266
Merged
jsmariegaard merged 2 commits intomainfrom Sep 22, 2023
Merged
Conversation
ecomodeller
approved these changes
Sep 22, 2023
Member
ecomodeller
left a comment
ecomodeller
left a comment
There was a problem hiding this comment.
I guess you are moving things around in order to have functions to keep in matching.py to eventually get rid entirely of connection.py.
It is a bit difficult to see from the diff if any from_matched() or compare() actually changed apart from being moved.
Member
Author
Not changed. Just moved. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mini-PR to ease further re-factoring and avoid merge conflicts