Skip to content

Make plotting api more consistent#267

Merged
jsmariegaard merged 36 commits intomainfrom
Make-consistent-plotting-API
Oct 12, 2023
Merged

Make plotting api more consistent#267
jsmariegaard merged 36 commits intomainfrom
Make-consistent-plotting-API

Conversation

@ryan-kipawa
Copy link
Copy Markdown
Collaborator

@ryan-kipawa ryan-kipawa commented Sep 28, 2023

Mainly limited to:

  • Do they include ax, figsize, and title as params
  • Do they return ax

@ryan-kipawa
Add test setup to dynamically find plotting funcs
d1bf802
@ryan-kipawa
Add failing tests to check if plot params exist
2535040
@ryan-kipawa
Add test to check for axes return annot and doc
0ed3f70
@ryan-kipawa
Add missing docstring for taylor_diagram
cc3d41a
@ryan-kipawa
Update wind_rose params, annotations, docstr
9590f55
@ryan-kipawa
Update temporal_coverage return annotation and doc
ffd4bfb
@ryan-kipawa
Update spatial_overview return annotation and doc
7da8adc
@ryan-kipawa
Update taylor_diagram params, docstr, and ret anno
1c5fde1
@ryan-kipawa
Update scatter parms, return annot, and docs
ab548f1
@ryan-kipawa
Add kde figsize, title. Update return annot to ax
df2ea78
@ryan-kipawa
ax cannot be passed to plotly backend
5049841
@ryan-kipawa
Merge branch 'main' into Make-consistent-plotting-API
338aba2
@ryan-kipawa
Timeseries plot accepts / ret ax
335d55c
@ryan-kipawa
Add test for plotting functions to not return none
541c027
@ryan-kipawa
Add comparer plot tests for ax, title, figsize
a879851
@ryan-kipawa
Hist accepts ax and figsize
ff1b2a1
@ryan-kipawa
KDE consistent way to get ax
327df95
@ryan-kipawa
qq use explicit instead of implicit
4a2556d
@ryan-kipawa
Add figsize to box and consistent get ax
1a9c6f4
@ryan-kipawa
Remove rough plot api tests from standard pytest
ce3964e
@ryan-kipawa
Scatter uses implicit methods and fix cbar alpha
c1a6442
@ryan-kipawa
Taylor plot return sfigure, does not accept ax
408b00b
@ryan-kipawa
Add figsize and ax params to residual_his
98ae25d
@ryan-kipawa
FIx linting errors
203bde3
@ryan-kipawa
Fix mypy errors
bef1e01
@ryan-kipawa
Fix title test for older matplotlib versions
6b3b709
@ryan-kipawa
Add tests for comparer collection
5b2ad3e
@ryan-kipawa
Add ax param for cc plotter
078a51a
@ryan-kipawa
Add figsize, title to kde plot on collections
004d7b2
@ryan-kipawa
Add ax, figsize to collection hist plot
2c9d6cc
@ryan-kipawa ryan-kipawa marked this pull request as ready for review October 11, 2023 08:47
ecomodeller
ecomodeller approved these changes Oct 11, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@ecomodeller ecomodeller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

jsmariegaard
jsmariegaard approved these changes Oct 12, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@jsmariegaard jsmariegaard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic! Thanks a lot

@jsmariegaard jsmariegaard merged commit ebc26ad into main Oct 12, 2023
@jsmariegaard jsmariegaard deleted the Make-consistent-plotting-API branch October 12, 2023 14:03
@jsmariegaard jsmariegaard mentioned this pull request Nov 19, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ecomodeller ecomodeller ecomodeller approved these changes

@jsmariegaard jsmariegaard jsmariegaard approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ryan-kipawa @ecomodeller @jsmariegaard