Merged
Conversation
ecomodeller
reviewed
Nov 14, 2023
notebooks/CSO_events.ipynb
Outdated
| "outputs": [], | ||
| "source": [ | ||
| "# Import data\n", | ||
| "os.chdir('C:\\\\Users\\\\rpal\\\\Source\\\\modelskill\\\\tmp\\\\RPAL\\\\data\\\\obs_and_model_data_Rocco')\n", |
Member
There was a problem hiding this comment.
Pro tip, don't use absolute paths😉
Also removed the CSO_events, which was the wrong notebook.
Collaborator
Author
|
@ecomodeller I've removed the old test notebook and included the right one with the necessary data (this time with relative path). Also tried to keep the test data as compact as possible by reducing the time resolution when possible. |
ecomodeller
approved these changes
Nov 22, 2023
Member
ecomodeller
left a comment
ecomodeller
left a comment
There was a problem hiding this comment.
Not all imported libraries are necessary in the notebook, e.g. os, numpy and plotly
Plotly is used, and is not installed by default, so it might be useful to mention.
I have made some changes to the csv file.
- Changed the event column from float to integer to more clearly indicate that these are discrete events
- Set very small values e.g. 1e-30 to exactly 0.0.
jsmariegaard
approved these changes
Nov 24, 2023
Member
jsmariegaard
left a comment
jsmariegaard
left a comment
There was a problem hiding this comment.
Nice work!
Removed unused imports.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.