Skip to content

Circular metrics (again)#284

Merged
jsmariegaard merged 33 commits intomainfrom
circular_metrics
Dec 13, 2023
Merged

Circular metrics (again)#284
jsmariegaard merged 33 commits intomainfrom
circular_metrics

Conversation

@ecomodeller
Copy link
Copy Markdown
Member

@ecomodeller ecomodeller commented Nov 22, 2023

Start over and copy/paste some metrics from #235

@jsmariegaard
Copy link
Copy Markdown
Member

jsmariegaard commented Nov 27, 2023

It is not easy to change an existing quantity to "circular" as the quantity is immutable.

How should we help the users set "circular" in quantity? If the name is something with "direction" and the unit is "degree" then it is probably circular...

And what about radians? Should we also support data in radians? If not I think we should at least provide an error.

@jsmariegaard
Copy link
Copy Markdown
Member

jsmariegaard commented Dec 6, 2023

@stkistner @daniel-caichac-DHI , we implemented for you guys in the metocean team 😃

It now features circular versions of metrics (for degrees not radians): bias, mae, rmse, max_error, urmse. Do you need more? Which ones?

@jsmariegaard jsmariegaard mentioned this pull request Dec 6, 2023
Closed
@daniel-caichac-DHI
Copy link
Copy Markdown
Collaborator

daniel-caichac-DHI commented Dec 7, 2023

I think those statistics are fine for now. thanks a lot.
We could use the same data used in the wind rose for testing/ example , right?

@ecomodeller ecomodeller marked this pull request as ready for review December 13, 2023 07:36
@jsmariegaard jsmariegaard self-requested a review December 13, 2023 13:13
jsmariegaard
jsmariegaard approved these changes Dec 13, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@jsmariegaard jsmariegaard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it!

@jsmariegaard jsmariegaard merged commit 30736b8 into main Dec 13, 2023
@jsmariegaard jsmariegaard deleted the circular_metrics branch December 13, 2023 13:21
@daniel-caichac-DHI
Copy link
Copy Markdown
Collaborator

daniel-caichac-DHI commented Dec 13, 2023

I'm afraid to do a pull request of modelskill by now and see how all my wrappers fail :D

@ecomodeller
Copy link
Copy Markdown
Member Author

ecomodeller commented Dec 13, 2023

I'm afraid to do a pull request of modelskill by now and see how all my wrappers fail :D

On friday you will have a versioned release of modelskill to rely on.

@jsmariegaard jsmariegaard mentioned this pull request Dec 13, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jsmariegaard jsmariegaard jsmariegaard approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ecomodeller @jsmariegaard @daniel-caichac-DHI