Merged
Conversation
jsmariegaard
approved these changes
Dec 6, 2023
Member
jsmariegaard
left a comment
jsmariegaard
left a comment
There was a problem hiding this comment.
Great work!
In the longer run, I guess it would be nice to the model_result function have the actual implementation and let the obsolete ModelResult call that function. But I guess this doesn't matter too much.
By the way, how about deprecation warning 🤔...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The class
ModelResultdoesn't return an instance ofModelResultbut instead creates DfsuModelResult, PointModelResult etc. which is confusing.This PR changes this to use a factory function where it should be clearer that it returns one of these classes.