Merged
Conversation
jsmariegaard
approved these changes
Dec 11, 2023
Member
jsmariegaard
left a comment
jsmariegaard
left a comment
There was a problem hiding this comment.
Check out the suggestion - otherwise great!
modelskill/matching.py
Outdated
| set(data.data_vars) | ||
| ): | ||
| raise ValueError( | ||
| f"Model and observation have overlapping variables: {overlapping_names}" |
Member
There was a problem hiding this comment.
Could we be even more helpful here and tell which observation and which model?
(and I guess it could also be a clash between items from two different model results? )
f"Overlapping variables (item names) found when matching observation {observation.name} with Model {mri.name}; overlapping variable names: {overlapping_names}"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Observation and model might have identically named aux_items.
Previously the aux_item from the obs was silently overwritten by aux_item from model.
This PR doesn't allow that.