Addition of Wastewater notebook example and dataset#336
Merged
jsmariegaard merged 4 commits intomainfrom Dec 22, 2023
Merged
Conversation
jsmariegaard
approved these changes
Dec 22, 2023
Member
jsmariegaard
left a comment
jsmariegaard
left a comment
There was a problem hiding this comment.
Great stuff @ChrisGaszynski-DHI ! I made some smaller edits for consistency with other notebooks and temporarily disabled the interactive timeseries plots as they are not rendered on GitHub.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a notebook with an example of how we would use ModelSkill in Wastewater. The data has been anonymized. This is an example of comparing model outputs in our DigitalTwin. I would also like to try and use the tool for model calibration when I get some time in the future.
Please feel free to change / add whatever you like. I might have missed some cool features.
PS, sorry for the delay, things have been busy!