Merged
Conversation
Member
|
@jannik-el I suggested you as reviewer for this PR which addresses the problem you encountered. Please reach out to @ecomodeller if you need guidance on how to do a PR review :-) |
jannik-el
reviewed
Sep 10, 2024
There was a problem hiding this comment.
This change is not directly related to the issue - not aware of how specific you are on this, I don't see it as an issue if all tests passed.
Member
Author
There was a problem hiding this comment.
True. But we are pragmatic.😉
jannik-el
approved these changes
Sep 10, 2024
jannik-el
left a comment
jannik-el
left a comment
There was a problem hiding this comment.
All changes reviewed, have tested on my specific issue which caused the error and it passed, also tried some general tests to check and all looks good.
As far as I can tell all edge cases are already covered by other tests and relevant errors messages.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.