Use strings as values for enum instead of integers#469
Merged
jsmariegaard merged 5 commits intomainfrom Dec 12, 2024
Merged
Conversation
Member
Author
|
Turns out you can use strings as the backing values for enums, which makes it trivial to construct given the correct string. Question is do we still need/want to support the more flexible version? modelskill/modelskill/types.py Line 22 in 36cc9a2 |
jsmariegaard
reviewed
Dec 4, 2024
Member
Author
|
Static type checks fails, we need to merge #470 first. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Inspiration from From stringly typed to strongly typed: Insights from re-designing a library