Skip to content

Raw model data is PointModelResult#497

Merged
ecomodeller merged 1 commit intomainfrom
fix/raw_model_data
Jan 8, 2025
Merged

Raw model data is PointModelResult#497
ecomodeller merged 1 commit intomainfrom
fix/raw_model_data

Conversation

@ecomodeller
Copy link
Copy Markdown
Member

No description provided.

@jsmariegaard
Copy link
Copy Markdown
Member

Why was it TimeSeries in the first place? What was the benefit of that?

@jsmariegaard
Copy link
Copy Markdown
Member

Closes #496

@ecomodeller
Copy link
Copy Markdown
Member Author

I think the idea was to make clear that we are only relying on method in the TimeSeries class, which has fewer methods and attributes than the PointModelResult.

@ecomodeller ecomodeller merged commit f2acbd3 into main Jan 8, 2025
@ecomodeller ecomodeller deleted the fix/raw_model_data branch January 8, 2025 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Loading a saved Comparer/ComparerCollection restores raw-model-data as PointObservation

2 participants