Imrove skill_table styling/spacing in plt.scatter#503
Merged
ecomodeller merged 6 commits intomainfrom Feb 14, 2025
Merged
Conversation
daniel-caichac-DHI
approved these changes
Feb 14, 2025
Collaborator
daniel-caichac-DHI
left a comment
daniel-caichac-DHI
left a comment
There was a problem hiding this comment.
I think this is legit.
@ecomodeller can we merge?
ecomodeller
approved these changes
Feb 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates
Legend and SkillTable are now better aligned - relative to each other as well as the axis-limits.
Improved spacing for with and without colorbar conditions.
Improved sizing of
skill_table. The implementation is a bit hacky, but is much more reliableAdded standard options for
skill_tableBug fix
scatter legend never used the fontsize argument
Examples
The new implementation at work for standard and MOOD styling
Like, what even is this?
