Test common calibration workflow - enforce unique model names#514
Merged
ecomodeller merged 7 commits intomainfrom Oct 6, 2025
Merged
Test common calibration workflow - enforce unique model names#514ecomodeller merged 7 commits intomainfrom
ecomodeller merged 7 commits intomainfrom
Conversation
ryan-kipawa
approved these changes
Oct 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The default behavior of MIKE FM is to create to store outputs in a folder based on the name of the setup file.

E.g. in this case the file
flow.dfsuwould be found in the folderoresund_1.m21fm - Result FilesUsing the filename (
os.path.basename) as the default name for a model result, is thus not likely to be unique.I don't think
modelskill.matchshould allow multiple models with the same name.But dealing with a single model it seems completely unnecessary to name a model result.