Skip to content

Conversation

@nickwilliams-zaxiom
Copy link
Contributor

@nickwilliams-zaxiom nickwilliams-zaxiom commented Sep 21, 2023

When I commented orbsvcs/tests in the exclude block and then ran MWC and Make, git status revealed a host of new untracked files due to MWC and Make creating new files throughout this directory. The best solution I could come up with to keep these files out of Git was to add a bunch of new .gitignore files and update several existing .gitignore files. This will prevent this problem going forward for other developers. These are the only changes in this pull request.

If the context helps, this is the Bash command that I used to generate these changes automatically after MWC and Make:

$ (export IFS=$'\n'; for line in $(git status --short --untracked-files); \
    do if [[ $line == '??'* ]]; \
    then file="${line:3}"; d="$(dirname "${file}")"; f="$(basename "${file}")"; \
    echo "${f}" >> "${d}/.gitignore"; fi; done)

@mitza-oci
Copy link
Member

I suggest adding a cross-platform script to the repo to maintain these files going forward. See https://github.com/OpenDDS/OpenDDS/blob/master/tools/scripts/update_gitignore.pl for an example

.gitignore Outdated
Comment on lines 54 to 60

# compiled test binaries, so that git status doesn't show untracked files
/ACE/protocols/examples/INet/ftp_simple_wget
/ACE/protocols/examples/INet/http_simple_wget
/ACE/protocols/tests/HTBP/Send_Recv_Tests/client
/ACE/protocols/tests/HTBP/Send_Recv_Tests/server
/ACE/protocols/tests/INet/MT_Get/mt_get
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These tend to be easier to manage when they're in the local .gitignore for the project's directory

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moving those now

@nickwilliams-zaxiom
Copy link
Contributor Author

nickwilliams-zaxiom commented Sep 28, 2023

I suggest adding a cross-platform script to the repo to maintain these files going forward. See https://github.com/OpenDDS/OpenDDS/blob/master/tools/scripts/update_gitignore.pl for an example

Happy to do that, but do you have a suggestion for where in the directory structure I should place this?

@mitza-oci
Copy link
Member

I suggest adding a cross-platform script to the repo to maintain these files going forward. See https://github.com/OpenDDS/OpenDDS/blob/master/tools/scripts/update_gitignore.pl for an example

Happy to do that, but do you have a suggestion for where in the directory structure I should place this?

It could go in ACE/bin/ but it doesn't have to. Any suggestions @jwillemsen @iguessthislldo or others?

@nickwilliams-zaxiom
Copy link
Contributor Author

I suggest adding a cross-platform script to the repo to maintain these files going forward. See https://github.com/OpenDDS/OpenDDS/blob/master/tools/scripts/update_gitignore.pl for an example

Happy to do that, but do you have a suggestion for where in the directory structure I should place this?

It could go in ACE/bin/ but it doesn't have to. Any suggestions @jwillemsen @iguessthislldo or others?

I went with ACE/bin/, committed, and pushed.

@mitza-oci mitza-oci merged commit 51e1e2c into DOCGroup:master Oct 6, 2023
@nickwilliams-zaxiom nickwilliams-zaxiom deleted the add_gitignores branch October 9, 2023 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants