Skip to content

Tax explorer#28

Open
adrian-brady wants to merge 12 commits intomainfrom
tax-explorer-route
Open

Tax explorer#28
adrian-brady wants to merge 12 commits intomainfrom
tax-explorer-route

Conversation

@adrian-brady
Copy link
Copy Markdown
Contributor

WIP tax explorer route. Needs work to be more responsive and needs real components for the graphs. No API requests are made, instead using mock data for now.

Desktop
image

iPhone SE
image

@cloudflare-workers-and-pages
Copy link
Copy Markdown

cloudflare-workers-and-pages bot commented Mar 15, 2026

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Preview URL Updated (UTC)
✅ Deployment successful!
View logs
st-madison-frontend bf21e4b Commit Preview URL

Branch Preview URL
Mar 16 2026, 09:46 PM

Copy link
Copy Markdown
Member

@the-snesler the-snesler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good for a WIP! Beyond the lack of responsive design, some things I notice:

  • The nav link says "Tax Explorer", the page title says "Parcel Explorer", and the route is /tax-explorer. They should probably all be the same thing. This could also the the homepage of the app instead of a separate page if we wanted?
  • PropertyDetailsDropdown opens on button click but has no mechanism to close when clicking outside. This is a common UX expectation. My team is going to need dropdowns too so we could pull in a library like Floating UI https://floating-ui.com/
  • PropertySearch only triggers on Enter key. We could have a search button too.
  • Values like "$85,000" and "7,200 sqft" are strings in the mock JSON. When the real API endpoints are set up, these are probably going to be numbers.
  • AssessmentsTable.svelte and LandEfficiencyTable.svelte have nearly identical <style> blocks (~35 lines each). Could we use a shared .css file or component?
  • AssessmentsTable uses '-' as fallback, while LandEfficiencyTable and PropertyDetailsDropdown use '—' (em dash). a sign of LLM usage perhaps?
  • BreakdownBarChart assumes exactly 4 bars (x={15 + i * 24} with viewBox 120px wide). If the number of years changes, bars will overflow or be misaligned. Could make the layout dynamic based on bars.length.
  • The caret is a plain v character. we have the technology for icons, we can use icons
  • The barColors record will silently return undefined for any source label not in the map. Maybe add a fallback color.

@adrian-brady
Copy link
Copy Markdown
Contributor Author

yeah i had claude help me with a decent chunk of this as I just couldn't get myself inspired over the weekend. I will make some changes and update the PR @the-snesler

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants