Open
Conversation
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
st-madison-frontend | bf21e4b | Commit Preview URL Branch Preview URL |
Mar 16 2026, 09:46 PM |
the-snesler
approved these changes
Mar 16, 2026
Member
There was a problem hiding this comment.
This looks good for a WIP! Beyond the lack of responsive design, some things I notice:
- The nav link says "Tax Explorer", the page title says "Parcel Explorer", and the route is /tax-explorer. They should probably all be the same thing. This could also the the homepage of the app instead of a separate page if we wanted?
- PropertyDetailsDropdown opens on button click but has no mechanism to close when clicking outside. This is a common UX expectation. My team is going to need dropdowns too so we could pull in a library like Floating UI https://floating-ui.com/
- PropertySearch only triggers on Enter key. We could have a search button too.
- Values like "$85,000" and "7,200 sqft" are strings in the mock JSON. When the real API endpoints are set up, these are probably going to be numbers.
- AssessmentsTable.svelte and LandEfficiencyTable.svelte have nearly identical <style> blocks (~35 lines each). Could we use a shared .css file or component?
- AssessmentsTable uses '-' as fallback, while LandEfficiencyTable and PropertyDetailsDropdown use '—' (em dash). a sign of LLM usage perhaps?
- BreakdownBarChart assumes exactly 4 bars (x={15 + i * 24} with viewBox 120px wide). If the number of years changes, bars will overflow or be misaligned. Could make the layout dynamic based on bars.length.
- The caret is a plain v character. we have the technology for icons, we can use icons
- The barColors record will silently return undefined for any source label not in the map. Maybe add a fallback color.
Contributor
Author
|
yeah i had claude help me with a decent chunk of this as I just couldn't get myself inspired over the weekend. I will make some changes and update the PR @the-snesler |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WIP tax explorer route. Needs work to be more responsive and needs real components for the graphs. No API requests are made, instead using mock data for now.
Desktop

iPhone SE
