Conversation
Bump eslint to ^10.0.3 and add @eslint/js and globals as explicit
devDependencies (no longer bundled with ESLint 10). Bump Node engine
requirement to >=20.19.0 to match ESLint 10's minimum.
Fix all new lint errors from updated eslint:recommended:
- preserve-caught-error: add { cause } to re-thrown errors (35 sites)
- no-useless-assignment: remove redundant default cases (3 sites)
Closes #391
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Codecov Report❌ Patch coverage is @@ Coverage Diff @@
## main #415 +/- ##
==========================================
+ Coverage 82.39% 82.41% +0.02%
==========================================
Files 49 49
Lines 7036 7033 -3
Branches 2121 2121
==========================================
- Hits 5797 5796 -1
+ Misses 485 484 -1
+ Partials 754 753 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1 file with indirect coverage changes 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Upgrades ESLint from v9 to v10, completing the migration tracked in #391.
eslintto^10.0.3@eslint/jsandglobalsas explicit devDependencies (no longer bundled with ESLint 10)engines.nodefrom>=20.10.0to>=20.19.0(ESLint 10 minimum)eslint:recommended:preserve-caught-error(35 sites): adds{ cause }to re-thrown errors, preserving error chainsno-useless-assignment(3 sites): removes redundantdefault: comparison = 0in sort switchesPrep work done in #414 (removed
eslint-plugin-importblocker).Closes #391
Test plan
npm run checkpasses (typecheck + lint + format)npm test— 2069 unit tests passnpm run test:integration— all pass except pre-existingdownload-artifact-streamingfailures (same on main)🤖 Generated with Claude Code