# Flow diagram for updated containsExecutableJavaScript SVG check

[Dargon789]

Reviewer's Guide

Replaces DOMPurify-based SVG JavaScript detection with a cheerio and regex-based approach in the injected helpers, updates dependencies accordingly, and removes the sw-build GitHub workflow.

Flow diagram for updated containsExecutableJavaScript SVG check

flowchart TD
  A["containsExecutableJavaScript(svgString)"] --> B{svgString is empty?}
  B -- Yes --> Z["Return false"]
  B -- No --> C["Try parse svgString with cheerio.load(svgString, xmlMode true)"]

  C --> D{Any script elements?}
  D -- Yes --> E["Return true"]
  D -- No --> F["Continue"]
  C -->|Parsing throws| F

  F["Define eventHandlerRegex and hrefJavaScriptRegex"] --> G{eventHandlerRegex matches svgString?}
  G -- Yes --> H["Return true"]
  G -- No --> I{hrefJavaScriptRegex matches svgString?}
  I -- Yes --> J["Return true"]
  I -- No --> K["Return false"]

Loading

File-Level Changes

Change	Details	Files
Refactor SVG executable JavaScript detection to avoid DOMPurify and instead use cheerio parsing with regex fallbacks.	Replace DOMPurify import with cheerio and update type-only imports to remain unchanged. Implement cheerio-based XML parsing of SVG strings to detect <script> tags, wrapped in a try/catch for robustness. Add regex-based fallbacks to detect inline event handlers and javascript: URLs in href/xlink:href attributes when parsing fails. Ensure the helper returns true on any suspicious construct and false otherwise.	packages/injected/src/helpers.ts
Align package dependencies with new implementation and example tooling.	Swap dompurify dependency for cheerio in the injected package to match the new SVG detection implementation. Downgrade css-loader in the vanilla JS example to a 6.x version, likely for compatibility with the rest of the toolchain.	packages/injected/package.json examples/with-vanilla-js/package.json
Remove the Subwallet build GitHub Actions workflow.	Delete the sw-build.yml workflow configuration, disabling that CI job.	.github/workflows/sw-build.yml

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

Originally posted by @sourcery-ai[bot] in #44 (comment)