Revert 4248 tomas/apkt 2695 bug extension wallet send flow resets confirm send view

[Dargon789]

Description

Please include a brief summary of the change.

Type of change

• Chore (non-breaking change that addresses non-functional tasks, maintenance, or code quality improvements)
• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)

Associated Issues

For Linear issues: Closes APKT-xxx
For GH issues: closes #...

Showcase (Optional)

If there is a UI change include the screenshots with before and after state.
If new feature is being introduced, include the link to demo recording.

Checklist

• Code in this PR is covered by automated tests (Unit tests, E2E tests)
• My changes generate no new warnings
• I have reviewed my own code
• I have filled out all required sections
• I have tested my changes on the preview link
• Approver of this PR confirms that the changes are tested on the preview link

Summary by Sourcery

Revert changes to the send token flow in the wallet, removing async/await handling and simplifying error management

Bug Fixes:

• Simplified error handling in token send methods across different blockchain namespaces

Enhancements:

• Removed loading state management from send token methods
• Simplified transaction sending logic in SendController

Tests:

• Removed some test cases related to loading state and send flow

[codesandbox]

Review or Edit in CodeSandbox

Open the branch in Web Editor • VS Code • Insiders

Open Preview

[bolt-new-by-stackblitz]

Run & review this pull request in StackBlitz Codeflow.

[sourcery-ai]

Reviewer's Guide by Sourcery

This pull request reverts changes related to the send flow, specifically addressing an issue where the confirm send view was being reset. The changes include refactoring the sendToken function, improving error handling, and removing associated tests and UI elements related to the loading state.

Sequence diagram for sendEvmToken

sequenceDiagram
  participant W3mWalletSendPreviewView
  participant SendController
  participant ChainController
  participant AccountController
  participant ConnectionController
  participant SnackController
  participant EventsController

  W3mWalletSendPreviewView->>SendController: onSendClick()
  SendController->>SendController: sendToken()
  SendController->>ChainController: activeCaipNetwork?.chainNamespace
  alt chainNamespace is 'eip155'
    SendController->>SendController: sendEvmToken()
    SendController->>AccountController: state.preferredAccountTypes
    SendController->>SendController: sendERC20Token()
    SendController->>CoreHelperUtil: getPlainAddress(tokenAddress)
    SendController->>ConnectionController: writeContract(params)
    activate ConnectionController
    ConnectionController-->>SendController: Success/Error
    deactivate ConnectionController
    alt Success
      SendController->>SnackController: showSuccess('Transaction started')
      SendController->>SendController: resetSend()
    else Error
      SendController->>EventsController: sendEvent(SEND_ERROR)
      SendController->>SnackController: showError('Something went wrong')
    end
  end

Loading

Sequence diagram for sendNativeToken

sequenceDiagram
  participant W3mWalletSendPreviewView
  participant SendController
  participant ChainController
  participant AccountController
  participant ConnectionController
  participant SnackController
  participant EventsController
  participant RouterController

  W3mWalletSendPreviewView->>SendController: onSendClick()
  SendController->>SendController: sendToken()
  SendController->>ChainController: activeCaipNetwork?.chainNamespace
  alt chainNamespace is 'eip155'
    SendController->>SendController: sendEvmToken()
    SendController->>AccountController: state.preferredAccountTypes
    SendController->>SendController: sendNativeToken(params)
    SendController->>RouterController: pushTransactionStack({view: 'Account', goBack: false})
    SendController->>ConnectionController: sendTransaction(params)
    activate ConnectionController
    ConnectionController-->>SendController: Success/Error
    deactivate ConnectionController
    alt Success
      SendController->>SnackController: showSuccess('Transaction started')
      SendController->>EventsController: sendEvent(SEND_SUCCESS)
      SendController->>SendController: resetSend()
    else Error
      SendController->>EventsController: sendEvent(SEND_ERROR)
      SendController->>SnackController: showError('Something went wrong')
    end
  end

Loading

File-Level Changes

Change	Details	Files
Refactors the sendToken function in SendController to remove the try...finally block and setLoading calls, streamlining the token sending process.	Removes the try...finally block from sendToken. Removes this.setLoading(true) at the beginning of the sendToken function. Removes this.setLoading(false) in the finally block of the sendToken function.	packages/controllers/src/controllers/SendController.ts
Makes sendEvmToken and sendNativeToken synchronous and handles transaction sending and error display within sendNativeToken using try...catch.	Removes the async keyword from the sendEvmToken function. Removes the async keyword from the sendNativeToken function. Adds a try...catch block in sendNativeToken to handle transaction sending and error display. Displays a success message using SnackController.showSuccess after a successful transaction in sendNativeToken. Displays an error message using SnackController.showError if sending the transaction fails in sendNativeToken. Adds error logging using console.error in the catch block of sendNativeToken. Adds event tracking for send errors in sendNativeToken.	packages/controllers/src/controllers/SendController.ts
Improves error handling and feedback for sendERC20Token by wrapping the transaction logic in a try...catch block and displaying appropriate snackbar messages.	Wraps the ERC20 token sending logic in a try...catch block. Displays a success message using SnackController.showSuccess after a successful transaction. Displays an error message using SnackController.showError if sending the transaction fails. Adds error logging using console.error in the catch block. Adds event tracking for send errors.	packages/controllers/src/controllers/SendController.ts
Adds error handling and feedback to sendSolanaToken using promises and snackbar messages.	Adds a check for valid amount and receiver address, displaying an error message if either is missing. Uses promises to handle the asynchronous sendTransaction call. Displays a success message and resets the send state on successful transaction. Displays an error message if the transaction fails. Adds error logging using console.error in the catch block.	packages/controllers/src/controllers/SendController.ts
Removes tests related to redirection and loading state in W3mWalletSendPreviewView.	Removes the test case for redirection to the account view on successful send. Removes the test case for showing the loading state during sending.	packages/scaffold-ui/test/views/w3m-wallet-send-preview-view.test.ts
Removes the loading state and updates the onSendClick method in W3mWalletSendPreviewView to directly call SendController.sendToken without awaiting or handling the result.	Removes the @state() private loading property. Removes this.loading = val.loading from the subscription. Removes the .loading=${this.loading} property from the wui-button element. Updates the onSendClick method to directly call SendController.sendToken. Removes the try...catch block from the onSendClick method. Removes the RouterController.replace('Account') call from the onSendClick method.	packages/scaffold-ui/src/views/w3m-wallet-send-preview-view/index.ts
Removes the changeset file.	Removes the .changeset/nine-socks-make.md file.	.changeset/nine-socks-make.md

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!
• Generate a plan of action for an issue: Comment @sourcery-ai plan on
  an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
appkit-demo	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Apr 21, 2025 5:03am
appkit-demo-df32	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Apr 21, 2025 5:03am
appkit-walletkit	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Apr 21, 2025 5:03am

[snyk-io]

🎉 Snyk checks have passed. No issues have been found so far.

✅ security/snyk check is complete. No issues have been found. (View Details)

[sourcery-ai]

Hey @Dargon789 - I've reviewed your changes - here's some feedback:

Overall Comments:

• Consider adding try/catch blocks to sendEvmToken and sendSolanaToken to handle potential errors.
• The removal of async and try/finally block in sendToken might have unintended consequences; ensure that loading states are still handled correctly.

Here's what I looked at during the review

• 🟡 General issues: 1 issue found
• 🟢 Security: all looks good
• 🟢 Testing: all looks good
• 🟡 Complexity: 1 issue found
• 🟢 Documentation: all looks good

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[github-actions]

Coverage Report

Status	Category	Percentage	Covered / Total
🔵	Lines	74.7%	25336 / 33916
🔵	Statements	74.7%	25336 / 33916
🔵	Functions	66.22%	2141 / 3233
🔵	Branches	83.12%	4896 / 5890

File Coverage

File	Stmts	Branches	Functions	Lines	Uncovered Lines
Changed Files
packages/controllers/src/controllers/SendController.ts	51.43%	69.81%	58.53%	51.43%	69, 119-121, 123, 148-169, 212-226, 234-235, 247-248, 260-316, 335, 337-352, 354-371, 375-399, 139-368
packages/scaffold-ui/src/views/w3m-wallet-send-preview-view/index.ts	89.02%	71.42%	85.71%	89.02%	42-47, 128, 139, 142

Generated in workflow #135 for commit a6dcb3d by the Vitest Coverage Report Action