Feat(UI) apkt 2592 make wui ux by reown clickable #760
Conversation
|
|
Review or Edit in CodeSandboxOpen the branch in Web Editor • VS Code • Insiders |
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
Summary of ChangesHello @Dargon789, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly expands the capabilities of the Reown AppKit ecosystem by integrating Bitcoin and TON networks into the browser extension, providing a more versatile multi-chain experience. Concurrently, the demo application has been extensively refactored to offer dynamic and persistent configuration options for chains, networks, and wallet features, enhancing its utility for showcasing AppKit's flexibility. These changes are complemented by robust new end-to-end tests and comprehensive updates to developer tooling and documentation, aiming to improve development workflows and maintain code quality across the project. Highlights
Ignored Files
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request introduces significant updates across the AppKit monorepo, focusing on enhanced wallet functionality, improved developer tooling, and better project maintenance. Key changes include adding Bitcoin and TON support to the browser extension, implementing a new useAppKitWallets hook for custom UI, and deferring Coinbase SDK initialization in ethers adapters. Bug fixes address issues with profile wallet tab order, in-app browser wallet buttons, and Base Account SDK connections. Project infrastructure is updated with new Dependabot configurations for automated dependency management, size-limit for bundle size tracking, and new Cursor rules for code quality and development processes. ESLint and GitHub issue templates are also refined. Review comments highlight the need for safer error handling in the Bitcoin provider by explicitly checking for undefined private keys, logging errors in the TON provider's event listener, and adding a TODO comment for Bitcoin balance fetching. Additionally, a suggestion was made to cast node to HTMLElement in DemoPage.ts to avoid @ts-expect-error and to wrap several context provider functions in useCallback for performance optimization.
Signed-off-by: Dargon789 <64915515+Dargon789@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> Signed-off-by: Dargon789 <64915515+Dargon789@users.noreply.github.com>
b999df8 to
c412338
Compare
Description
Please include a brief summary of the change.
Type of change
Associated Issues
For Linear issues: Closes APKT-xxx
For GH issues: closes #...
Showcase (Optional)
If there is a UI change include the screenshots with before and after state.
If new feature is being introduced, include the link to demo recording.
Checklist